Skip to content

[Fix] Jetpack force logout on accounts with no sites #19749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 7, 2022
Merged

[Fix] Jetpack force logout on accounts with no sites #19749

merged 1 commit into from
Dec 7, 2022
+2 −10

Conversation

@alpavanoglu
Copy link
Contributor

@alpavanoglu alpavanoglu commented Dec 7, 2022

Fixes #19426

Fixes the issue where user with no sites would be logged out on Jetpack every time they killed the app.

To test:

  1. Get a WP.com account with no blogs.
  2. Sign in to the Jetpack app using the account.
  3. Kill the app after signed in.
  4. Launch the app again.
  5. User should still be logged in.

Regression Notes

  1. Potential unintended areas of impact
    This issue could be affected as it reverts the condition added in that PR.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    I confirmed that case is no longer valid as now we offer Site Creating in Jetpack as well. So the "no sites message" with "Try Again" button is not shown anymore.

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@alpavanoglu alpavanoglu added this to the 21.4 milestone Dec 7, 2022
@alpavanoglu alpavanoglu changed the title Remove hasBlogs check from JetpackWindowManager [Fix] Jetpack force logout on accounts with no sites Dec 7, 2022
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Dec 7, 2022

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

@salimbraksa salimbraksa self-requested a review December 7, 2022 12:16
@alpavanoglu alpavanoglu mentioned this pull request Dec 7, 2022
Closed
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Dec 7, 2022

You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19749-3f88ce5 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Dec 7, 2022

You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19749-3f88ce5 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@salimbraksa
Copy link
Contributor

salimbraksa commented Dec 7, 2022

I confirm this works as expected. I created an account with no sites. And re-starting the app didn't log out the user. Also, the showUI logic in Jetpack is now similar to WordPress's version. LGTM! 🚀

CleanShot 2022-12-07 at 14 46 47@2x

@alpavanoglu alpavanoglu merged commit ffcf588 into trunk Dec 7, 2022
@alpavanoglu alpavanoglu deleted the fix/logout-jp-on-no-blog branch December 7, 2022 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@salimbraksa salimbraksa salimbraksa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Jetpack App [Type] Bug

Projects

None yet

Milestone

21.4

Development

Successfully merging this pull request may close these issues.

User with no blogs can't stay signed in on Jetpack app

4 participants

@alpavanoglu @wpmobilebot @salimbraksa